pysim[master]: Fix select control parameter

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri Mar 31 11:52:44 UTC 2017


Patch Set 1: Code-Review+1

(2 comments)

doesn't hurt, but...

https://gerrit.osmocom.org/#/c/2174/1/pySim/cards.py
File pySim/cards.py:

Line 428: 		self._scc.sel_ctrl = "000C"
why are the get_ / set_ methods added when no-one is actually using them? Every sim card model would simply set it in the constructor, right?


https://gerrit.osmocom.org/#/c/2174/1/pySim/commands.py
File pySim/commands.py:

Line 51: 			data, sw = self._tp.send_apdu_checksw(self.cla_byte + "a4" + self._sel_ctrl + "02" + i)
this also doesn't use sel_ctrl()


-- 
To view, visit https://gerrit.osmocom.org/2174
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1993a267c952bf37d5de1cb4e1107f445614c17b
Gerrit-PatchSet: 1
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list