libosmocore[master]: gsm0808: Add utils for Cell Identifier List

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Mar 30 17:34:48 UTC 2017


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/2181/2/include/osmocom/gsm/protocol/gsm_08_08.h
File include/osmocom/gsm/protocol/gsm_08_08.h:

Line 457: struct gsm0808_cell_id_list {
also here, I would generally try to avoid resorting to linked lists and dynamic allocations.  The length ofthe Cell ID List IE is limited to 256 bytes (one-octet length), and thus the total number of call_id's in the list can be computed from that.  We can put an array of the maximum number of possible Cell Identifiers in the 'struct gsm0808_cell_id_list.


-- 
To view, visit https://gerrit.osmocom.org/2181
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I625245dd1dd396fc2bc189e8cd2c444a33042528
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list