osmo-trx[master]: vector: Introduce segmentMove() method to move data inside o...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Tom Tsou gerrit-no-reply at lists.osmocom.org
Thu Mar 23 23:11:50 UTC 2017


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/2156/1/CommonLibs/Vector.h
File CommonLibs/Vector.h:

PS1, Line 231: const
This method modifies protected member data block and I do not believe should declared const.

Yes, the class compiles and is strictly valid because the data, start, and end member pointers are not modified. But, it's hard to say that the Vector object is unchanged after segmentMove() is called, which is what const implies.


-- 
To view, visit https://gerrit.osmocom.org/2156
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f3f4267b4137a0bc031f27e0f896fba9b9f3433
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Alexander Chemeris <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Tom Tsou <tom at tsou.cc>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list