This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Tom Tsou gerrit-no-reply at lists.osmocom.orgPatch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/2136/1/Transceiver52M/Transceiver.cpp File Transceiver52M/Transceiver.cpp: Line 609: float toa, max = -1.0, avg = 0.0; > There's no need to move variable declaration. Is there good reason not to move it? I prefer the moved declaration. Moving the variable limits scope, which is generally good practice. OsmoTRX uses C++ and I see no reason to adhere to C89 standards or convensions. https://gerrit.osmocom.org/#/c/2136/1/Transceiver52M/sigProcLib.cpp File Transceiver52M/sigProcLib.cpp: PS1, Line 1725: Generally avoid per-line argument lists unless there is a good reason for readability. I'm aware that with C++ and the origins of the codebase, strictly having Osmocom/Linux kernel coding style is not practical. But, this is one case where the declaration clearly does not need to take up two lines. -- To view, visit https://gerrit.osmocom.org/2136 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9bf97f2dc03fea9bebcf43198dfb05f6e4694e9c Gerrit-PatchSet: 1 Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Owner: Alexander Chemeris <Alexander.Chemeris at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Tom Tsou <tom at tsou.cc> Gerrit-HasComments: Yes