This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Patch Set 4: Code-Review-1
(2 comments)
https://gerrit.osmocom.org/#/c/2031/3/openbsc/include/openbsc/gsm_data_shared.h
File openbsc/include/openbsc/gsm_data_shared.h:
Line 844: const struct value_string gsm_chreq_descs[7];
> is it here ok with the number? or sould we use
elsewhere we use
extern const struct value_string my_names[];
but I guess it's fine to stay consistent with the surroundings. We can remove the explicit sizes in a separate commit, if that makes sense.
https://gerrit.osmocom.org/#/c/2031/3/openbsc/src/libcommon/gsm_data_shared.c
File openbsc/src/libcommon/gsm_data_shared.c:
Line 54: const struct value_string gsm_chreq_descs[7] = {
probably keep the 7 here as well, too.
--
To view, visit https://gerrit.osmocom.org/2031
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I23d3be5610a5a46098d2b12feed4245828599aae
Gerrit-PatchSet: 4
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-HasComments: Yes