openbsc[master]: pcu_sock: add basic pcu interface support

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Mar 15 13:31:26 UTC 2017


Patch Set 1: -Code-Review

(3 comments)

https://gerrit.osmocom.org/#/c/2056/1/openbsc/include/openbsc/pcu_if.h
File openbsc/include/openbsc/pcu_if.h:

Line 13: 	struct osmo_fd conn_bfd;	/* fd for connection to lcr */
to lrc?!?


https://gerrit.osmocom.org/#/c/2056/1/openbsc/src/libbsc/bsc_init.c
File openbsc/src/libbsc/bsc_init.c:

Line 534: 		strcpy(pcu_sock_path, PCU_SOCK_DEFAULT);
osmo_strlcpy for bounds checking?


https://gerrit.osmocom.org/#/c/2056/1/openbsc/src/libbsc/pcu_sock.c
File openbsc/src/libbsc/pcu_sock.c:

Line 1: /* pcu_sock.c: Connect from PCU via unix domain socket */
the question here is still if this code could/should be generalized and shared between the PCU socket inside the BTS and the one inside the BSC.


-- 
To view, visit https://gerrit.osmocom.org/2056
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib13cb4099d12fa71e9e0b8727e19ab29e11909b2
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list