openbsc[master]: pcu_sock: Send non-NULL hLayer1 to PCU

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Tue Mar 14 15:20:23 UTC 2017


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/2060/1/openbsc/src/libbsc/pcu_sock.c
File openbsc/src/libbsc/pcu_sock.c:

Line 226: 		info_ind->trx[i].hlayer1 = 0x2342;
I think this deserves detailed comment next to it, otherwise it looks like confusing magic number out of nowhere.


-- 
To view, visit https://gerrit.osmocom.org/2060
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8170bd4134904702b6b272e496100361ba473cbc
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list