This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
lynxis lazus gerrit-no-reply at lists.osmocom.orgReview at https://gerrit.osmocom.org/2057 pcu_sock: Don't re-implement core functionality like gsm_bts_trx_num() Change-Id: I5ea506c8240dac124ccf5522d02ba18e4f0cb90d --- M openbsc/src/libbsc/pcu_sock.c 1 file changed, 2 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/57/2057/1 diff --git a/openbsc/src/libbsc/pcu_sock.c b/openbsc/src/libbsc/pcu_sock.c index b2bc425..0f3dc1b 100644 --- a/openbsc/src/libbsc/pcu_sock.c +++ b/openbsc/src/libbsc/pcu_sock.c @@ -58,18 +58,6 @@ [PCU_IF_SAPI_PTCCH] = "PTCCH", }; -static struct gsm_bts_trx *trx_by_nr(struct gsm_bts *bts, uint8_t trx_nr) -{ - struct gsm_bts_trx *trx; - - llist_for_each_entry(trx, &bts->trx_list, list) { - if (trx->nr == trx_nr) - return trx; - } - - return NULL; -} - /* Check if BTS has a PCU connection */ static bool pcu_connected(struct gsm_bts *bts) { @@ -232,7 +220,7 @@ } for (i = 0; i < 8; i++) { - trx = trx_by_nr(bts, i); + trx = gsm_bts_trx_num(bts, i); if (!trx) break; info_ind->trx[i].pdch_mask = 0; @@ -427,7 +415,7 @@ /* release PDCH */ for (i = 0; i < 8; i++) { - trx = trx_by_nr(bts, i); + trx = gsm_bts_trx_num(bts, i); if (!trx) break; for (j = 0; j < 8; j++) { -- To view, visit https://gerrit.osmocom.org/2057 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5ea506c8240dac124ccf5522d02ba18e4f0cb90d Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>