libosmocore[master]: osmo_auth_gen_vec: UMTS auth: fix SQN increment

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Mar 14 13:37:31 UTC 2017


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/2049/1/include/osmocom/crypt/auth.h
File include/osmocom/crypt/auth.h:

Line 42: 			unsigned int ind; /*!< nr of bits not in SEQ, only SQN */
I think ind and i are not very clearly separated and could easily be mistaken.  Let's use num_ind_bits or ind_bit_width or ind_size or whatever you think is fit to cearly INDicate, we are talking about a size in bits, not just in the comments.


-- 
To view, visit https://gerrit.osmocom.org/2049
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc97e1736a797ffcbf8c1f7d41c5c4518f4e41bf
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list