[PATCH] openbsc[master]: libbsc: add chreq type for CHREQ_T_PDCH_ONE_PHASE & CHREQ_T_...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Tue Mar 14 13:23:16 UTC 2017


Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/1360

to look at the new patch set (#7).

libbsc: add chreq type for CHREQ_T_PDCH_ONE_PHASE & CHREQ_T_PDCH_TWO_PHASE

When using a BSC located PCU the BSC must understand PDCH requests.

Change-Id: Ie7f4ed000cf1b40d269873cf0ddf5ff9f5bbc18a
---
M openbsc/include/openbsc/gsm_data.h
M openbsc/include/openbsc/gsm_data_shared.h
M openbsc/src/libbsc/gsm_04_08_utils.c
3 files changed, 16 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/60/1360/7

diff --git a/openbsc/include/openbsc/gsm_data.h b/openbsc/include/openbsc/gsm_data.h
index a36083a..e9ba173 100644
--- a/openbsc/include/openbsc/gsm_data.h
+++ b/openbsc/include/openbsc/gsm_data.h
@@ -360,7 +360,7 @@
 		enum rrlp_mode mode;
 	} rrlp;
 
-	enum gsm_chan_t ctype_by_chreq[16];
+	enum gsm_chan_t ctype_by_chreq[18];
 
 	/* Use a TCH for handling requests of type paging any */
 	int pag_any_tch;
diff --git a/openbsc/include/openbsc/gsm_data_shared.h b/openbsc/include/openbsc/gsm_data_shared.h
index 7c469ee..e697cb8 100644
--- a/openbsc/include/openbsc/gsm_data_shared.h
+++ b/openbsc/include/openbsc/gsm_data_shared.h
@@ -46,6 +46,7 @@
 	GSM_CHREQ_REASON_CALL,
 	GSM_CHREQ_REASON_LOCATION_UPD,
 	GSM_CHREQ_REASON_OTHER,
+	GSM_CHREQ_REASON_PDCH,
 };
 
 /* lchans 0..3 are SDCCH in combined channel configuration,
diff --git a/openbsc/src/libbsc/gsm_04_08_utils.c b/openbsc/src/libbsc/gsm_04_08_utils.c
index 4a53b31..db9dabb 100644
--- a/openbsc/src/libbsc/gsm_04_08_utils.c
+++ b/openbsc/src/libbsc/gsm_04_08_utils.c
@@ -75,7 +75,11 @@
 	{ 0x67, 0xff, CHREQ_T_LMU },
 	{ 0x60, 0xf9, CHREQ_T_RESERVED_SDCCH },
 	{ 0x61, 0xfb, CHREQ_T_RESERVED_SDCCH },
-	{ 0x63,	0xff, CHREQ_T_RESERVED_SDCCH },
+	{ 0x63, 0xff, CHREQ_T_RESERVED_SDCCH },
+	{ 0x70, 0xf8, CHREQ_T_PDCH_TWO_PHASE },
+	{ 0x78, 0xfc, CHREQ_T_PDCH_ONE_PHASE },
+	{ 0x78, 0xfa, CHREQ_T_PDCH_ONE_PHASE },
+	{ 0x78, 0xf9, CHREQ_T_PDCH_ONE_PHASE },
 	{ 0x7f, 0xff, CHREQ_T_RESERVED_IGNORE },
 };
 
@@ -92,7 +96,11 @@
 	{ 0x67, 0xff, CHREQ_T_LMU },
 	{ 0x60, 0xf9, CHREQ_T_RESERVED_SDCCH },
 	{ 0x61, 0xfb, CHREQ_T_RESERVED_SDCCH },
-	{ 0x63,	0xff, CHREQ_T_RESERVED_SDCCH },
+	{ 0x63, 0xff, CHREQ_T_RESERVED_SDCCH },
+	{ 0x70, 0xf8, CHREQ_T_PDCH_TWO_PHASE },
+	{ 0x78, 0xfc, CHREQ_T_PDCH_ONE_PHASE },
+	{ 0x78, 0xfa, CHREQ_T_PDCH_ONE_PHASE },
+	{ 0x78, 0xf9, CHREQ_T_PDCH_ONE_PHASE },
 	{ 0x7f, 0xff, CHREQ_T_RESERVED_IGNORE },
 };
 
@@ -112,6 +120,8 @@
 	[CHREQ_T_PAG_R_TCH_FH]		= GSM_LCHAN_TCH_F,
 	[CHREQ_T_LMU]			= GSM_LCHAN_SDCCH,
 	[CHREQ_T_RESERVED_SDCCH]	= GSM_LCHAN_SDCCH,
+	[CHREQ_T_PDCH_ONE_PHASE]	= GSM_LCHAN_PDTCH,
+	[CHREQ_T_PDCH_TWO_PHASE]	= GSM_LCHAN_PDTCH,
 	[CHREQ_T_RESERVED_IGNORE]	= GSM_LCHAN_UNKNOWN,
 };
 
@@ -130,6 +140,8 @@
 	[CHREQ_T_PAG_R_TCH_F]		= GSM_CHREQ_REASON_PAG,
 	[CHREQ_T_PAG_R_TCH_FH]		= GSM_CHREQ_REASON_PAG,
 	[CHREQ_T_LMU]			= GSM_CHREQ_REASON_OTHER,
+	[CHREQ_T_PDCH_ONE_PHASE]	= GSM_CHREQ_REASON_PDCH,
+	[CHREQ_T_PDCH_TWO_PHASE]	= GSM_CHREQ_REASON_PDCH,
 	[CHREQ_T_RESERVED_SDCCH]	= GSM_CHREQ_REASON_OTHER,
 	[CHREQ_T_RESERVED_IGNORE]	= GSM_CHREQ_REASON_OTHER,
 };

-- 
To view, visit https://gerrit.osmocom.org/1360
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie7f4ed000cf1b40d269873cf0ddf5ff9f5bbc18a
Gerrit-PatchSet: 7
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>



More information about the gerrit-log mailing list