[PATCH] openbsc[master]: RBS2000 RSL: Support for sending RSL PAGING CMD for GPRS

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Mon Mar 13 09:04:55 UTC 2017


Review at  https://gerrit.osmocom.org/2039

RBS2000 RSL: Support for sending RSL PAGING CMD for GPRS

Change-Id: I66541f9b20e7fd67fbec329283fc3c821c970a56
---
M openbsc/include/openbsc/abis_rsl.h
M openbsc/src/libbsc/abis_rsl.c
M openbsc/src/libbsc/bsc_api.c
3 files changed, 9 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/39/2039/1

diff --git a/openbsc/include/openbsc/abis_rsl.h b/openbsc/include/openbsc/abis_rsl.h
index 758c555..692b464 100644
--- a/openbsc/include/openbsc/abis_rsl.h
+++ b/openbsc/include/openbsc/abis_rsl.h
@@ -22,6 +22,7 @@
 #ifndef _RSL_H
 #define _RSL_H
 
+#include <stdbool.h>
 #include <osmocom/gsm/protocol/gsm_08_58.h>
 #include <osmocom/gsm/gsm_utils.h>
 
@@ -49,7 +50,7 @@
 int rsl_chan_mode_modify_req(struct gsm_lchan *ts);
 int rsl_encryption_cmd(struct msgb *msg);
 int rsl_paging_cmd(struct gsm_bts *bts, uint8_t paging_group, uint8_t len,
-		   uint8_t *ms_ident, uint8_t chan_needed);
+		   uint8_t *ms_ident, uint8_t chan_needed, bool is_gprs);
 int rsl_imm_assign_cmd(struct gsm_bts *bts, uint8_t len, uint8_t *val);
 
 int rsl_data_request(struct msgb *msg, uint8_t link_id);
diff --git a/openbsc/src/libbsc/abis_rsl.c b/openbsc/src/libbsc/abis_rsl.c
index 26cafc2..91cbd46 100644
--- a/openbsc/src/libbsc/abis_rsl.c
+++ b/openbsc/src/libbsc/abis_rsl.c
@@ -1007,7 +1007,7 @@
 }
 
 int rsl_paging_cmd(struct gsm_bts *bts, uint8_t paging_group, uint8_t len,
-		   uint8_t *ms_ident, uint8_t chan_needed)
+		   uint8_t *ms_ident, uint8_t chan_needed, bool is_gprs)
 {
 	struct abis_rsl_dchan_hdr *dh;
 	struct msgb *msg = rsl_msgb_alloc();
@@ -1020,6 +1020,11 @@
 	msgb_tlv_put(msg, RSL_IE_MS_IDENTITY, len-2, ms_ident+2);
 	msgb_tv_put(msg, RSL_IE_CHAN_NEEDED, chan_needed);
 
+	/* Ericsson wants to have this IE in case a paging message
+	 * relates to packet paging */
+	if (bts->type == GSM_BTS_TYPE_RBS2000 && is_gprs)
+		msgb_tv_put(msg, RSL_IE_ERIC_PACKET_PAG_IND, 0);
+
 	msg->dst = bts->c0->rsl_link;
 
 	return abis_rsl_sendmsg(msg);
diff --git a/openbsc/src/libbsc/bsc_api.c b/openbsc/src/libbsc/bsc_api.c
index 54978e5..253326f 100644
--- a/openbsc/src/libbsc/bsc_api.c
+++ b/openbsc/src/libbsc/bsc_api.c
@@ -419,7 +419,7 @@
 int gsm0808_page(struct gsm_bts *bts, unsigned int page_group, unsigned int mi_len,
 		 uint8_t *mi, int chan_type)
 {
-	return rsl_paging_cmd(bts, page_group, mi_len, mi, chan_type);
+	return rsl_paging_cmd(bts, page_group, mi_len, mi, chan_type, false);
 }
 
 static void handle_ass_compl(struct gsm_subscriber_connection *conn,

-- 
To view, visit https://gerrit.osmocom.org/2039
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I66541f9b20e7fd67fbec329283fc3c821c970a56
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>



More information about the gerrit-log mailing list