openbsc[master]: Add MS time. offset to gsm_lchan

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Mar 6 17:16:23 UTC 2017


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/1699/2/openbsc/include/openbsc/gsm_data_shared.h
File openbsc/include/openbsc/gsm_data_shared.h:

Line 332: 	uint8_t ms_t_offs;
one option to avoid having these separate 'member + valid' fields would be to have an integer, and use negative/-1 for invalid.  You could even add a MS_TOFFS_INVALID #define to avoid the "-1 magic value"


-- 
To view, visit https://gerrit.osmocom.org/1699
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bda57c8d6c15bbb803eca708931556dae118a00
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list