This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Max gerrit-no-reply at lists.osmocom.orgReview at https://gerrit.osmocom.org/1974 osmo-bts-trx: cosmetic log fixes * print actual value causing error and the check range * fix log error message typo Change-Id: Ic36c0558cdbd1790c167f290a40007b42f5de65d --- M src/common/scheduler.c M src/osmo-bts-trx/gsm0503_coding.c 2 files changed, 14 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/74/1974/1 diff --git a/src/common/scheduler.c b/src/common/scheduler.c index 724fb5a..27b7630 100644 --- a/src/common/scheduler.c +++ b/src/common/scheduler.c @@ -305,11 +305,11 @@ goto wrong_type; } if (prim_fn > 100) { - LOGP(DL1C, LOGL_NOTICE, "Prim for trx=%u ts=%u at fn=%u " - "is out of range, or channel %s with type %s is " - "already disabled. If this happens in conjunction " - "with PCU, increase 'rts-advance' by 5. " - "(current fn=%u)\n", l1t->trx->nr, tn, + LOGP(DL1C, LOGL_NOTICE, "Prim %u for trx=%u ts=%u at " + "fn=%u is out of range (100), or channel %s with " + "type %s is already disabled. If this happens in " + "conjunction with PCU, increase 'rts-advance' by 5." + " (current fn=%u)\n", prim_fn, l1t->trx->nr, tn, l1sap->u.data.fn, get_lchan_by_chan_nr(l1t->trx, chan_nr)->name, get_value_string(trx_chan_type_names, chan), fn); @@ -1609,10 +1609,12 @@ no_data: /* in case of C0, we need a dummy burst to maintain RF power */ if (bits == NULL && l1t->trx == l1t->trx->bts->c0) { -if (0) if (chan != TRXC_IDLE) // hack - LOGP(DL1C, LOGL_DEBUG, "No burst data for %s fn=%u ts=%u " - "burst=%d on C0, so filling with dummy burst\n", - trx_chan_desc[chan].name, fn, tn, bid); +#if 0 + if (chan != TRXC_IDLE) // hack + LOGP(DL1C, LOGL_DEBUG, "No burst data for %s fn=%u ts=%u " + "burst=%d on C0, so filling with dummy burst\n", + trx_chan_desc[chan].name, fn, tn, bid); +#endif bits = (ubit_t *) dummy_burst; } diff --git a/src/osmo-bts-trx/gsm0503_coding.c b/src/osmo-bts-trx/gsm0503_coding.c index 4c4f7f1..9e04452 100644 --- a/src/osmo-bts-trx/gsm0503_coding.c +++ b/src/osmo-bts-trx/gsm0503_coding.c @@ -1687,7 +1687,7 @@ if (steal > 0) { rv = _xcch_decode_cB(tch_data, cB, n_errors, n_bits_total); if (rv) { - LOGP(DL1C, LOGL_NOTICE, "tch_fr_decode(): error decoding FACCH frame (%d/%d bits)\n", *n_errors, *n_bits_total); + LOGP(DL1C, LOGL_NOTICE, "tch_fr_decode(): error decoding FACCH/F frame (%d/%d bits)\n", *n_errors, *n_bits_total); return -1; } @@ -1823,7 +1823,7 @@ rv = _xcch_decode_cB(tch_data, cB, n_errors, n_bits_total); if (rv) { - LOGP(DL1C, LOGL_NOTICE, "tch_hr_decode(): error decoding FACCH frame (%d/%d bits)\n", *n_errors, *n_bits_total); + LOGP(DL1C, LOGL_NOTICE, "tch_hr_decode(): error decoding FACCH/H frame (%d/%d bits)\n", *n_errors, *n_bits_total); return -1; } @@ -1845,7 +1845,7 @@ rv = osmo_crc8gen_check_bits(&gsm0503_tch_fr_crc3, d + 73, 22, p); if (rv) { - LOGP(DL1C, LOGL_NOTICE, "tch_fr_decode(): error checking CRC8 for an HR frame\n"); + LOGP(DL1C, LOGL_NOTICE, "tch_hr_decode(): error checking CRC8 for an HR frame (%d/%d bits)\n", *n_errors, *n_bits_total); return -1; } -- To view, visit https://gerrit.osmocom.org/1974 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic36c0558cdbd1790c167f290a40007b42f5de65d Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de>