python/osmo-python-tests[master]: tcp debugging: allow switching on TCP debug by env var

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Mar 2 15:03:56 UTC 2017


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/1917/1/osmopy/obscvty.py
File osmopy/obscvty.py:

Line 30: debug_tcp_sockets = 'OSMOPY_DEBUG_TCP_SOCKETS' in os.environ
> does not allow to have it as ENV=0/1. Maybe os.getenv('..') == '1'?
my vision was to trigger on presence and avoid value validation for 1, yes, on, true, enabled checks, but if you want to be able to set to 0, fine with me. getenv != '0'?


-- 
To view, visit https://gerrit.osmocom.org/1917
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46212d07a2c1be05672a37766457e6c98b68f90d
Gerrit-PatchSet: 1
Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list