openbsc[master]: Fix BTS number in attribute requests

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Fri Jun 30 15:31:00 UTC 2017


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/2868/1/openbsc/src/libbsc/bsc_init.c
File openbsc/src/libbsc/bsc_init.c:

Line 346: 			abis_nm_get_attr(trx->bts, NM_OC_BTS, 0xFF, 0xFF, 0xFF, bts_attr, sizeof(bts_attr));
> I think removing trx->nr makes a lot of sens.  But for bts->nr, I'm not sur
The classic E1 should not be affected by this at all: the calls to oml_nm_get_attr() were added specifically for OS#1614 "better identification of BTS model" so any changes to it should not have effect on classic E1 BTS which would most likely ignore it.


-- 
To view, visit https://gerrit.osmocom.org/2868
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f43055c38000248033a8ff9ddaf0910d68d794b
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list