osmo-bts[master]: sysmo: Allow passing low quality buffers to upper layers

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Jun 30 03:16:03 UTC 2017


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/3056/3/src/osmo-bts-sysmo/l1_if.c
File src/osmo-bts-sysmo/l1_if.c:

PS3, Line 992: 1sap->u.data.lqual_cb
this is where/how we report linqQuality to the common part in l1sap.  I think it would make a lot of sense to remove the "drop frames in case of bad link quality from the BTS-specific parts and move it into the code above l1sap.  We'd have to add ber10k andlqual_cb to ph_tch_param, like we have it in ph_data_param already (libosmocore l1sap.h).


-- 
To view, visit https://gerrit.osmocom.org/3056
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5df8940fab833eb4e3ed851880b66987d356031
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list