[MERGED] libosmo-sccp[master]: gen_mtp_transfer_req_xua(): add addr to error log for missin...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Jun 26 16:11:36 UTC 2017


Harald Welte has submitted this change and it was merged.

Change subject: gen_mtp_transfer_req_xua(): add addr to error log for missing DPC
......................................................................


gen_mtp_transfer_req_xua(): add addr to error log for missing DPC

Change-Id: Icfd45bcbecc440b94893db2aca537a162f210abd
---
M src/sccp_scrc.c
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/sccp_scrc.c b/src/sccp_scrc.c
index a4ce34c..e44201a 100644
--- a/src/sccp_scrc.c
+++ b/src/sccp_scrc.c
@@ -26,6 +26,7 @@
 #include <sccp/sccp_types.h>
 #include <osmocom/sigtran/osmo_ss7.h>
 #include <osmocom/sigtran/sccp_sap.h>
+#include <osmocom/sigtran/sccp_helpers.h>
 #include <osmocom/sigtran/protocol/sua.h>
 #include <osmocom/sigtran/protocol/mtp.h>
 
@@ -125,7 +126,8 @@
 		xua->mtp.dpc = called->pc;
 	if (!xua->mtp.dpc) {
 		LOGP(DLSCCP, LOGL_ERROR, "MTP-TRANSFER.req from SCCP "
-			"without DPC?!?\n");
+			"without DPC?!? called=%s\n",
+			osmo_sccp_addr_dump(called));
 		return -1;
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/3013
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icfd45bcbecc440b94893db2aca537a162f210abd
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list