[MERGED] osmo-bts[master]: measurement: improve log output

[dexter]

dexter has submitted this change and it was merged.

Change subject: measurement: improve log output
......................................................................


measurement: improve log output

The code that receives the uplink measurement data from L1 does not
print the number of already received uplink measurements. Since
this is a valuable information when debugging the log output will
now print this information as well.

(Patch by Octasic Inc.)

Change-Id: I79926f25de088571fcc2c14388c72fc968c2d382
---
M src/common/measurement.c
1 file changed, 7 insertions(+), 4 deletions(-)

Approvals:
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Neels Hofmeyr: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/measurement.c b/src/common/measurement.c
index 6050001..dba3543 100644
--- a/src/common/measurement.c
+++ b/src/common/measurement.c
@@ -146,13 +146,16 @@
 		gsm_lchan_name(lchan), lchan->meas.num_ul_meas);
 
 	if (lchan->state != LCHAN_S_ACTIVE) {
-		LOGP(DMEAS, LOGL_NOTICE, "%s measurement during state: %s\n",
-			gsm_lchan_name(lchan), gsm_lchans_name(lchan->state));
+		LOGP(DMEAS, LOGL_NOTICE,
+		     "%s measurement during state: %s, num_ul_meas=%d\n",
+		     gsm_lchan_name(lchan), gsm_lchans_name(lchan->state),
+		     lchan->meas.num_ul_meas);
 	}
 
 	if (lchan->meas.num_ul_meas >= ARRAY_SIZE(lchan->meas.uplink)) {
-		LOGP(DMEAS, LOGL_NOTICE, "%s no space for uplink measurement\n",
-			gsm_lchan_name(lchan));
+		LOGP(DMEAS, LOGL_NOTICE,
+		     "%s no space for uplink measurement, num_ul_meas=%d\n",
+		     gsm_lchan_name(lchan), lchan->meas.num_ul_meas);
 		return -ENOSPC;
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/2930
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I79926f25de088571fcc2c14388c72fc968c2d382
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>