[PATCH] osmo-bts[master]: measurement: Remove dead code

[Harald Welte]

Review at  https://gerrit.osmocom.org/3031

measurement: Remove dead code

We used to have trx_meas_check_compute() and call that from the
bts-specific code in order to iterate over all timeslots and all lchans
in the timeslots if we have to send measurement reports.  This was
executed once per frame, and created unequal CPU load over time, which
in turn might increase different per-ts jitter.

Since 2f028c4e2c29f63df9926435466aa35377947767 in April 2017 we have
lchan_meas_check_compute(), which performs this on a per-lchan basis,
and hence CPU load is distributed over all active timeslots.

Change-Id: I6308cefe4a51e55719ea4ed4d613d3782b805c08
---
M include/osmo-bts/measurement.h
M src/common/measurement.c
2 files changed, 0 insertions(+), 39 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/31/3031/1

diff --git a/include/osmo-bts/measurement.h b/include/osmo-bts/measurement.h
index 87c8109..47b31a2 100644
--- a/include/osmo-bts/measurement.h
+++ b/include/osmo-bts/measurement.h
@@ -6,8 +6,6 @@
 
 int lchan_new_ul_meas(struct gsm_lchan *lchan, struct bts_ul_meas *ulm);
 
-int trx_meas_check_compute(struct gsm_bts_trx *trx, uint32_t fn);
-
 int lchan_meas_check_compute(struct gsm_lchan *lchan, uint32_t fn);
 
 #endif
diff --git a/src/common/measurement.c b/src/common/measurement.c
index 6ddc05a..6050001 100644
--- a/src/common/measurement.c
+++ b/src/common/measurement.c
@@ -320,40 +320,3 @@
 
 	return 1;
 }
-
-static int ts_meas_check_compute(struct gsm_bts_trx_ts *ts, uint32_t fn)
-{
-	int i;
-	const int num_subslots = ts_subslots(ts);
-
-	for (i = 0; i < num_subslots; ++i) {
-		struct gsm_lchan *lchan = &ts->lchan[i];
-
-		if (lchan->state != LCHAN_S_ACTIVE)
-			continue;
-
-		switch (lchan->type) {
-		case GSM_LCHAN_SDCCH:
-		case GSM_LCHAN_TCH_F:
-		case GSM_LCHAN_TCH_H:
-		case GSM_LCHAN_PDTCH:
-			lchan_meas_check_compute(lchan, fn);
-			break;
-		default:
-			break;
-		}
-	}
-	return 0;
-}
-
-/* needs to be called once every TDMA frame ! */
-int trx_meas_check_compute(struct gsm_bts_trx *trx, uint32_t fn)
-{
-	int i;
-
-	for (i = 0; i < ARRAY_SIZE(trx->ts); i++) {
-		struct gsm_bts_trx_ts *ts = &trx->ts[i];
-		ts_meas_check_compute(ts, fn);
-	}
-	return 0;
-}

-- 
To view, visit https://gerrit.osmocom.org/3031
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6308cefe4a51e55719ea4ed4d613d3782b805c08
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>