[PATCH] libosmocore[master]: configure.ac: Fix C(PP)FLAGS for BSD build

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Fri Jun 23 09:23:40 UTC 2017


Review at  https://gerrit.osmocom.org/3024

configure.ac: Fix C(PP)FLAGS for BSD build

If we pass CFLAGS params to configure, then the CFLAGS set inside
configure.ac are not applied and the build fails if -Werror is enabled
because then BUILDING_LIBOSMOCORE is not defined.

Seeing the following output at configure time in FreeBSD build:
./configure: CFLAGS+= -fsanitize=address -fsanitize=undefined: not found
./configure: CPPFLAGS+= -fsanitize=address -fsanitize=undefined: not found
./configure: CFLAGS+= -DBUILDING_LIBOSMOCORE -Wall: not found
./configure: CPPFLAGS+= -DBUILDING_LIBOSMOCORE -Wall: not found

Change-Id: I692bbc66e5343998eec360a02a3a1fe73478c5c6
---
M configure.ac
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/24/3024/1

diff --git a/configure.ac b/configure.ac
index 64de4bf..92544b6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -231,12 +231,12 @@
 	[sanitize=$enableval], [sanitize="no"])
 if test x"$sanitize" = x"yes"
 then
-	CFLAGS+=" -fsanitize=address -fsanitize=undefined"
-	CPPFLAGS+=" -fsanitize=address -fsanitize=undefined"
+	CFLAGS="$CFLAGS -fsanitize=address -fsanitize=undefined"
+	CPPFLAGS="$CPPFLAGS -fsanitize=address -fsanitize=undefined"
 fi
 
-CFLAGS+=" -DBUILDING_LIBOSMOCORE -Wall"
-CPPFLAGS+=" -DBUILDING_LIBOSMOCORE -Wall"
+CFLAGS="$CFLAGS -DBUILDING_LIBOSMOCORE -Wall"
+CPPFLAGS="$CPPFLAGS -DBUILDING_LIBOSMOCORE -Wall"
 
 AC_ARG_ENABLE(simd,
 	[AS_HELP_STRING(

-- 
To view, visit https://gerrit.osmocom.org/3024
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I692bbc66e5343998eec360a02a3a1fe73478c5c6
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>



More information about the gerrit-log mailing list