This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has submitted this change and it was merged.
Change subject: Fix compilation warnings: use correct log type for uint32_t
......................................................................
Fix compilation warnings: use correct log type for uint32_t
Change-Id: Ic1e3255800999669ca9619bfceb4124c773eff2d
---
M src/gsm/gsm48.c
M src/utils.c
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Vadim Yanitskiy: Looks good to me, but someone else must approve
Neels Hofmeyr: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/gsm/gsm48.c b/src/gsm/gsm48.c
index f69eee2..10e2b80 100644
--- a/src/gsm/gsm48.c
+++ b/src/gsm/gsm48.c
@@ -27,6 +27,7 @@
#include <stdio.h>
#include <string.h>
#include <stdbool.h>
+#include <inttypes.h>
#include <osmocom/core/utils.h>
#include <osmocom/core/byteswap.h>
@@ -637,7 +638,7 @@
/* Table 10.5.4.3, reverse generate_mid_from_tmsi */
if (mi_len == GSM48_TMSI_LEN && mi[0] == (0xf0 | GSM_MI_TYPE_TMSI)) {
tmsi = osmo_load32be(&mi[1]);
- return snprintf(string, str_len, "%u", tmsi);
+ return snprintf(string, str_len, "%"PRIu32, tmsi);
}
break;
case GSM_MI_TYPE_IMSI:
diff --git a/src/utils.c b/src/utils.c
index 9e3414b..a1881f0 100644
--- a/src/utils.c
+++ b/src/utils.c
@@ -26,6 +26,7 @@
#include <stdint.h>
#include <errno.h>
#include <stdio.h>
+#include <inttypes.h>
#include <osmocom/core/utils.h>
#include <osmocom/core/bit64gen.h>
@@ -54,7 +55,7 @@
if (str)
return str;
- snprintf(namebuf, sizeof(namebuf), "unknown 0x%x", val);
+ snprintf(namebuf, sizeof(namebuf), "unknown 0x%"PRIx32, val);
namebuf[sizeof(namebuf) - 1] = '\0';
return namebuf;
}
--
To view, visit https://gerrit.osmocom.org/2962
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic1e3255800999669ca9619bfceb4124c773eff2d
Gerrit-PatchSet: 4
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>