[MERGED] libosmocore[master]: gsm0411_utils.c: Fix compilation warnings

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Fri Jun 23 09:08:58 UTC 2017


Pau Espin Pedrol has submitted this change and it was merged.

Change subject: gsm0411_utils.c: Fix compilation warnings
......................................................................


gsm0411_utils.c: Fix compilation warnings

gsm0411_utils.c:102:2: warning: #warning find a portable way to obtain timezone offset [-Wcpp]
 #warning find a portable way to obtain timezone offset

gsm0411_utils.c: In function 'gsm338_get_sms_alphabet':
gsm0411_utils.c:260:4: warning: large integer implicitly truncated to unsigned type [-Woverflow]
    return 0xffffffff;

Change-Id: I1d6cb31f38721f79e2cf93f9b8e4776f3720aa07
---
M src/gsm/gsm0411_utils.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Neels Hofmeyr: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/gsm/gsm0411_utils.c b/src/gsm/gsm0411_utils.c
index 7c7164c..1d3ef49 100644
--- a/src/gsm/gsm0411_utils.c
+++ b/src/gsm/gsm0411_utils.c
@@ -100,7 +100,7 @@
 #ifdef HAVE_TM_GMTOFF_IN_TM
 	*scts++ = gsm411_bcdify(tm->tm_gmtoff/(60*15));
 #else
-#warning find a portable way to obtain timezone offset
+#pragma message ("find a portable way to obtain timezone offset")
 	*scts++ = 0;
 #endif
 }
@@ -258,7 +258,7 @@
 		if (cgbits & 2) {
 			LOGP(DLSMS, LOGL_NOTICE,
 			     "Compressed SMS not supported yet\n");
-			return 0xffffffff;
+			return -1;
 		}
 
 		switch ((dcs >> 2)&0x03) {

-- 
To view, visit https://gerrit.osmocom.org/2964
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1d6cb31f38721f79e2cf93f9b8e4776f3720aa07
Gerrit-PatchSet: 4
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>



More information about the gerrit-log mailing list