[MERGED] osmo-trx[master]: sigProcLib: Specify standard namespace for isnan()

[Tom Tsou]

Tom Tsou has submitted this change and it was merged.

Change subject: sigProcLib: Specify standard namespace for isnan()
......................................................................


sigProcLib: Specify standard namespace for isnan()

In commit a3dce85f
"sigProcLib: Use explicit NaN check in sinc table generation"

Use of std::isnan(double) was added without namespace specifier,
which may cause build issues depending on whether the C version
isnan() call is available. Add standard namespace to force C++
call usage and potential build issues.

Change-Id: I49328c43fdd690a4e6a2b2e949411aaf5674ead1
---
M Transceiver52M/sigProcLib.cpp
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Tom Tsou: Looks good to me, approved
  Harald Welte: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/Transceiver52M/sigProcLib.cpp b/Transceiver52M/sigProcLib.cpp
index 9d1ef49..e94170b 100644
--- a/Transceiver52M/sigProcLib.cpp
+++ b/Transceiver52M/sigProcLib.cpp
@@ -982,7 +982,7 @@
   for (int i = 0; i < TABLESIZE; i++) {
     auto x = (double) i / TABLESIZE * 8 * M_PI;
     auto y = sin(x) / x;
-    sincTable[i] = isnan(y) ? 1.0 : y;
+    sincTable[i] = std::isnan(y) ? 1.0 : y;
   }
 }
 

-- 
To view, visit https://gerrit.osmocom.org/2977
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I49328c43fdd690a4e6a2b2e949411aaf5674ead1
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Tom Tsou <tom at tsou.cc>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Tom Tsou <tom at tsou.cc>