This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Patch Set 5: Code-Review-1
(7 comments)
https://gerrit.osmocom.org/#/c/2924/5/include/osmocom/sigtran/sccp_sap.h
File include/osmocom/sigtran/sccp_sap.h:
Line 251: struct osmo_sccp_addr
(in above code, the '*' is with the struct, not one line below.)
https://gerrit.osmocom.org/#/c/2924/5/src/osmo_ss7_vty.c
File src/osmo_ss7_vty.c:
Line 1130: strcpy(entry->name,name);
*never* use strcpy()! strncpy() also has various pitfalls. We always use osmo_strlcpy(), here with sizeof(entry->name).
Line 1250: memset(&entry->addr.ip, 0, sizeof(entry->addr.ip));
(really needed?)
Line 1254: memset(&entry->addr.ip, 0, sizeof(entry->addr.ip));
on error, we should rather leave the original addr unchanged as it was before this call. i.e. first store to a local variable and then do entry->addr.ip.v4 = tmp_ip_v4;
Line 1278: memset(&entry->addr.ip, 0, sizeof(entry->addr.ip));
same as above
Line 1319: memset(&entry->addr.gt, 0, sizeof(entry->addr.gt));
(syntactically nicer:
entry->addr.gt = (struct osmo_sccp_gt){};
)
Line 1383: strcpy(entry->addr.gt.digits, argv[0]);
use osmo_strlcpy() with sizeof()
--
To view, visit https://gerrit.osmocom.org/2924
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I068ed7f7d113dab88424a9d47bab7fc703bb7942
Gerrit-PatchSet: 5
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes