This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/2930/1/src/common/measurement.c
File src/common/measurement.c:
PS1, Line 150: "%s measurement during state: %s, num_ul_meas=%d\n",
: gsm_lchan_name(lchan), gsm_lchans_name(lchan->state),
: lchan->meas.num_ul_meas);
> Let's don't mix tabs and spaces.
we have spaces following tabs throughout the Osmocom code base, often for multi-line param lists, also in this file, in order to align args with '('. Or am I missing something?
--
To view, visit https://gerrit.osmocom.org/2930
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I79926f25de088571fcc2c14388c72fc968c2d382
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-HasComments: Yes