This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 3: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/2820/3/src/gsm/gsm0808_utils.c File src/gsm/gsm0808_utils.c: Line 154: bool type_extended = false; each of below cases will set this variable (or assert). Hence, as I said before, do not initialize it here. Line 304: case GSM0808_SCT_HR1: combine this and two cases above! Always do so when the case body is identical. -- To view, visit https://gerrit.osmocom.org/2820 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idabb0f9620659557672e1c6b90c75481192e5c89 Gerrit-PatchSet: 3 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes