libosmocore[master]: gsm0808: add default speech codec configuration

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sun Jun 18 01:21:18 UTC 2017


Patch Set 3: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/#/c/2829/3/include/osmocom/gsm/protocol/gsm_08_08.h
File include/osmocom/gsm/protocol/gsm_08_08.h:

Line 452: /* Default speech codec configurations: Some codecs specified with
use doxygen API doc format


Line 459: 	 * for the Adaptive Multi-Rate Codec Types */
this and...


Line 466: 	 * Adaptive Multi-Rate – Wideband Codec Types */
...this should also go in above to-be API doc. There are doxygen inline comments available, but you'd have to repeat for each enum member. Since the comments name the values explicitly, let's just put this above as-is.


-- 
To view, visit https://gerrit.osmocom.org/2829
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9dc0165d76a022b2c1b7418bc3133407e61b7261
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list