libosmocore[master]: gsm0808: add function gsm0808_extrapolate_speech_codec()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sun Jun 18 01:10:37 UTC 2017


Patch Set 4: Code-Review-1

(4 comments)

https://gerrit.osmocom.org/#/c/2831/4/src/gsm/gsm0808_utils.c
File src/gsm/gsm0808_utils.c:

Line 688:  *  speech parameter 
(whitespace error)


Line 690:  *  \param[in] perm_spch value from where the speech codec is derived from
"value which the speech codec is derived from" and please also explicitly say which kind of value; the comment as it is leaves the reader guessing which constants or values might match this uint8_t.


Line 691:  *  \returns zero when successfull; negative on error */
"successful"


Line 695: 	/*! Note: This function accepts the permitted speech configuration
doxygen comment in the C block? Rather include this entire paragraph in above API doc for the function, e.g. separated by "blank" line below the param description (or between brief and params if you prefer that). Also best to stick to the imperative form, dropping things like "this function does".

  /*! \brief summary bla.
   *  \param ...
   *
   * Accept the permitted speech configuration from the channel type
   * information and compute an ...
   */


-- 
To view, visit https://gerrit.osmocom.org/2831
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I257c972e9fdf0dfe940a8d483447085bd62e50a2
Gerrit-PatchSet: 4
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list