This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Tom Tsou gerrit-no-reply at lists.osmocom.orgTom Tsou has submitted this change and it was merged. Change subject: sigProcLib: Fix complex/real vector flag in Laurent modulator ...................................................................... sigProcLib: Fix complex/real vector flag in Laurent modulator The modulator vector to be shaped by Laurent C1 pulse is complex, but was set as real. The error does not affect behaviour because we only support complex-complex and complex-real calculations; real-real convolution is not supported. So in this case the data vector was already assumed to be complex despite the improper flag setting. Change-Id: I03afc6a93a01fde7a9a02e4eb9d201d3ee37d21a --- M Transceiver52M/sigProcLib.cpp 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Tom Tsou: Looks good to me, approved Neels Hofmeyr: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/Transceiver52M/sigProcLib.cpp b/Transceiver52M/sigProcLib.cpp index 3a9a529..04391d6 100644 --- a/Transceiver52M/sigProcLib.cpp +++ b/Transceiver52M/sigProcLib.cpp @@ -643,7 +643,6 @@ c0_itr = c0_burst->begin(); c1_burst = new signalVector(burst_len, c1_pulse->size()); - c1_burst->isReal(true); c1_itr = c1_burst->begin(); /* Padded differential tail bits */ -- To view, visit https://gerrit.osmocom.org/2921 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03afc6a93a01fde7a9a02e4eb9d201d3ee37d21a Gerrit-PatchSet: 2 Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Owner: Tom Tsou <tom at tsou.cc> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Tom Tsou <tom at tsou.cc>