This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.org
Review at https://gerrit.osmocom.org/2938
cosmetic: Add info about corespondig codecs to permittet speech
The constants in enum gsm0808_permitted_speech are not very
expressive. This patch adds a comment which tells to which
codec the constand is coresponding.
Change-Id: I9734f7c261becffe38ffd41c304d006d08530c1a
---
M include/osmocom/gsm/protocol/gsm_08_08.h
1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/38/2938/1
diff --git a/include/osmocom/gsm/protocol/gsm_08_08.h b/include/osmocom/gsm/protocol/gsm_08_08.h
index 8aab9a9..ef55d49 100644
--- a/include/osmocom/gsm/protocol/gsm_08_08.h
+++ b/include/osmocom/gsm/protocol/gsm_08_08.h
@@ -394,14 +394,14 @@
/* GSM 08.08 3.2.2.11 Channel Type
* (see also 3GPP TS 48.008, section 3.2.2.11) */
enum gsm0808_permitted_speech {
- GSM0808_PERM_FR1 = 0x01,
- GSM0808_PERM_FR2 = 0x11,
- GSM0808_PERM_FR3 = 0x21,
+ GSM0808_PERM_FR1 = 0x01, /* GSM FR */
+ GSM0808_PERM_FR2 = 0x11, /* GSM EFR */
+ GSM0808_PERM_FR3 = 0x21, /* FR AMR */
GSM0808_PERM_FR4 = 0x41, /* OFR AMR-WB */
GSM0808_PERM_FR5 = 0x42, /* FR AMR-WB */
- GSM0808_PERM_HR1 = GSM0808_PERM_FR1 | 0x4,
- GSM0808_PERM_HR2 = GSM0808_PERM_FR2 | 0x4,
- GSM0808_PERM_HR3 = GSM0808_PERM_FR3 | 0x4,
+ GSM0808_PERM_HR1 = GSM0808_PERM_FR1 | 0x4, /* GSM HR */
+ GSM0808_PERM_HR2 = GSM0808_PERM_FR2 | 0x4, /* (deprecated) */
+ GSM0808_PERM_HR3 = GSM0808_PERM_FR3 | 0x4, /* HR AMR */
GSM0808_PERM_HR4 = 0x46, /* OHR AMR-WB */
GSM0808_PERM_HR6 = 0x45, /* OHR AMR */
};
--
To view, visit https://gerrit.osmocom.org/2938
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9734f7c261becffe38ffd41c304d006d08530c1a
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>