[PATCH] osmo-bts[master]: measurement: improve log output

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Fri Jun 16 12:51:08 UTC 2017


Review at  https://gerrit.osmocom.org/2930

measurement: improve log output

The code that receives the uplink measurement data from L1 does not
print the number of already received uplink measurements. Since
this is a valuable information when debugging the log output will
now print this information as well.

(Patch by Octasic Inc.)

Change-Id: I79926f25de088571fcc2c14388c72fc968c2d382
---
M src/common/measurement.c
1 file changed, 7 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/30/2930/1

diff --git a/src/common/measurement.c b/src/common/measurement.c
index 6ddc05a..d494a59 100644
--- a/src/common/measurement.c
+++ b/src/common/measurement.c
@@ -146,13 +146,16 @@
 		gsm_lchan_name(lchan), lchan->meas.num_ul_meas);
 
 	if (lchan->state != LCHAN_S_ACTIVE) {
-		LOGP(DMEAS, LOGL_NOTICE, "%s measurement during state: %s\n",
-			gsm_lchan_name(lchan), gsm_lchans_name(lchan->state));
+		LOGP(DMEAS, LOGL_NOTICE,
+		     "%s measurement during state: %s, num_ul_meas=%d\n",
+		     gsm_lchan_name(lchan), gsm_lchans_name(lchan->state),
+		     lchan->meas.num_ul_meas);
 	}
 
 	if (lchan->meas.num_ul_meas >= ARRAY_SIZE(lchan->meas.uplink)) {
-		LOGP(DMEAS, LOGL_NOTICE, "%s no space for uplink measurement\n",
-			gsm_lchan_name(lchan));
+		LOGP(DMEAS, LOGL_NOTICE,
+		     "%s no space for uplink measurement, num_ul_meas=%d\n",
+		     gsm_lchan_name(lchan), lchan->meas.num_ul_meas);
 		return -ENOSPC;
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/2930
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I79926f25de088571fcc2c14388c72fc968c2d382
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>



More information about the gerrit-log mailing list