libosmocore[master]: gsm0808: update permitted speech constants

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Jun 14 23:06:26 UTC 2017


Patch Set 4: Code-Review+1

(1 comment)

nitpick...

https://gerrit.osmocom.org/#/c/2811/4/include/osmocom/gsm/protocol/gsm_08_08.h
File include/osmocom/gsm/protocol/gsm_08_08.h:

Line 397: 	GSM0808_PERM_FR1	= 0x01,	/* GSM FR */
It would be good to keep the unrelated comment changes in a separate patch.

Above line has a tab before the comment, where below you're adding just a space in the same places.


-- 
To view, visit https://gerrit.osmocom.org/2811
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id426f7dbffe46450d0cf6df20236a9e68f065f8d
Gerrit-PatchSet: 4
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list