osmo-bts[master]: Move common steps into common jenkins helper

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Jun 12 18:50:28 UTC 2017


Patch Set 5: Code-Review-1

(2 comments)

I would prefer keeping the scripts entirely separate, and leaving jenkins_bts_model.sh as a mere "switch" between N completely standalone scripts. After this patch, you can't use e.g. jenkins_sysmobts.sh on its own anymore. Nothing against removing code dup, but if we really need to here, I would rather leave the jenkins_bts_model.sh unchanged, and place common parts in a new file that is sourced by each script (e.g.

    . "$(dirname "$0")/common.sh"

), so that each is still callable on its own (this is done in the osmo-gsm-tester scripts).

Also resolve these...

https://gerrit.osmocom.org/#/c/2894/5/contrib/jenkins_bts_model.sh
File contrib/jenkins_bts_model.sh:

Line 6: inst="$deps/install"
are these still duplicated in the individual scripts?


Line 21: osmo-deps.sh osmo-pcu
not all builds need this


-- 
To view, visit https://gerrit.osmocom.org/2894
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48b1f75179b9008d65219dd5a47c1ab3b886408
Gerrit-PatchSet: 5
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list