libosmocore[master]: Add macros to set/get/clear/toggle bit flags

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Jun 8 10:41:29 UTC 2017


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/2857/1/include/osmocom/core/utils.h
File include/osmocom/core/utils.h:

Line 24: #define OSMO_SET(x, flag) ((x) |= 1 << (flag))
I'd add _BIT_ to all of them, otherwise seems a bit too generic and you don't know what's doing at first glance:
OSMO_BIT_SET()


-- 
To view, visit https://gerrit.osmocom.org/2857
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9d38b837ce84649c2975dbe8b889fe3a769885f
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list