osmo-gsm-tester[master]: refactor: fix error handling; fix log.Origin; only one trial

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Jun 8 09:26:35 UTC 2017


Patch Set 5: Code-Review+2

(2 comments)

If you can find a way to move back the exception code inside test.run() please do, otherwise you can merge.

https://gerrit.osmocom.org/#/c/2853/2/selftest/suite_test.py
File selftest/suite_test.py:

Line 33:     results = s.run_tests('test_error.py')
> by printing the output, all of it is verified in the suite_test.ok file
Good point thanks


https://gerrit.osmocom.org/#/c/2853/5/src/osmo_gsm_tester/suite.py
File src/osmo_gsm_tester/suite.py:

Line 222:                 except Exception as e:
As I said on the other patch, moving this here seems ugly, but if there's not better way we can keep it here for now.


-- 
To view, visit https://gerrit.osmocom.org/2853
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf0846d457cab26f54c25e6906a8bb304724e2d8
Gerrit-PatchSet: 5
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list