osmo-gsm-tester[master]: error log: clarify for using more resources than reserved

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Jun 8 09:15:12 UTC 2017


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/2852/1/src/osmo_gsm_tester/resource.py
File src/osmo_gsm_tester/resource.py:

Line 483:                 msg = 'suite.conf reserved only %d x %r.' % (len(kind_reserved), kind)
> yes. If we reserved 4 modems in suite.conf, we can call suite.modem() four 
Are you perhaps checking the wrong way or I am missing something here? I'm not saying the context you describe cannot happen, it's just that something looks weird to me in these lines:

> kind_reserved = self.reserved.get(kind, [])
> used_count = len([r for r in kind_reserved if USED_KEY in r])
> elif not (used_count < len(kind_reserved)):

used_count is a subset of kind_reserved because you iterate over kind_reserved and only take the ones with USED_KEY defined, which means user_count is always <= len(kind_reserved). So, in the elif case actually the only case which can happen is: elif used_count >= len(kind_reserved) --> used_count == len(kind_reserved).

So at least it can be clarified/simplified like that I think, but I'm still not sure that's the logic you intend to do here.


-- 
To view, visit https://gerrit.osmocom.org/2852
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c67600ba69351859e46b8b2f368ee8106db0993
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list