This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 8: (4 comments) again marked in the new patch set ... earlier was in old patch set, sorry. Also added another spin on the register() thing. https://gerrit.osmocom.org/#/c/2779/8/src/osmo_gsm_tester/ofono_client.py File src/osmo_gsm_tester/ofono_client.py: Line 408: def scan_error_cb(self, obj, e, user_data): defer Line 411: def scan_result_cb(self, obj, result, user_data): defer Line 422: def register(self, scanned_operators): is a test script allowed to call register() directly? Is it only called from schedule_scan_register()? I guess this should be the scan_result_cb() instead of a separate function, and schedule_scan_register() should be called register() to be called by tests? Then from earlier comment: use the scanned_operators instead of ignoring and getting more properties from DBus in register_automatic(). Line 437: # won't act as a NO-OP, it actually returns an error). (nice) -- To view, visit https://gerrit.osmocom.org/2779 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d9eb47eac1044550d3885adb55105c304b0c15c Gerrit-PatchSet: 8 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-HasComments: Yes