[PATCH] libosmocore[master]: gsm0808: update permitted speech constants

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Thu Jun 1 10:25:28 UTC 2017


Hello Max, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/2811

to look at the new patch set (#3).

gsm0808: update permitted speech constants

3GPP TS 48.008 specifies two new half rate speech modes and two
new full rate speech modes. This patch adds the matching constants
to enum gsm0808_permitted_speech

Change-Id: Id426f7dbffe46450d0cf6df20236a9e68f065f8d
---
M include/osmocom/gsm/protocol/gsm_08_08.h
1 file changed, 12 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/11/2811/3

diff --git a/include/osmocom/gsm/protocol/gsm_08_08.h b/include/osmocom/gsm/protocol/gsm_08_08.h
index e5e7e1e..1e8d430 100644
--- a/include/osmocom/gsm/protocol/gsm_08_08.h
+++ b/include/osmocom/gsm/protocol/gsm_08_08.h
@@ -391,14 +391,19 @@
 	GSM0808_SPEECH_PERM_NO_CHANGE = 0x1f,
 };
 
-/* GSM 08.08 3.2.2.11 Channel Type */
+/* GSM 08.08 3.2.2.11 Channel Type
+ * (see also 3GPP TS 48.008, section 3.2.2.11) */
 enum gsm0808_permitted_speech {
-	GSM0808_PERM_FR1	= 0x01,
-	GSM0808_PERM_FR2	= 0x11,
-	GSM0808_PERM_FR3	= 0x21,
-	GSM0808_PERM_HR1	= GSM0808_PERM_FR1 | 0x4,
-	GSM0808_PERM_HR2	= GSM0808_PERM_FR2 | 0x4,
-	GSM0808_PERM_HR3	= GSM0808_PERM_FR3 | 0x4,
+	GSM0808_PERM_FR1	= 0x01,	/* GSM FR */
+	GSM0808_PERM_FR2	= 0x11, /* GSM EFR */
+	GSM0808_PERM_FR3	= 0x21, /* FR AMR */
+	GSM0808_PERM_FR4	= 0x41, /* OFR AMR-WB */
+	GSM0808_PERM_FR5	= 0x42, /* FR AMR-WB */
+	GSM0808_PERM_HR1	= GSM0808_PERM_FR1 | 0x4, /* GSM HR */
+	GSM0808_PERM_HR2	= GSM0808_PERM_FR2 | 0x4, /* (deprecated) */
+	GSM0808_PERM_HR3	= GSM0808_PERM_FR3 | 0x4, /* HR AMR */
+	GSM0808_PERM_HR4	= 0x46, /* OHR AMR-WB */
+	GSM0808_PERM_HR6	= 0x45, /* OHR AMR */
 };
 
 /* GSM 08.08 3.2.2.44 Chosen Encryption Algorithm */

-- 
To view, visit https://gerrit.osmocom.org/2811
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id426f7dbffe46450d0cf6df20236a9e68f065f8d
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>



More information about the gerrit-log mailing list