osmo-hlr[master]: VTY: Add hlr node and bind ip field

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Jun 1 09:33:59 UTC 2017


Patch Set 1:

(6 comments)

https://gerrit.osmocom.org/#/c/2809/1/doc/examples/osmo-hlr.cfg
File doc/examples/osmo-hlr.cfg:

Line 18:  bind ip 127.0.0.1
> name GSUP explicitly; either as another VTY parent node or as 'gsup bind ip
Done


https://gerrit.osmocom.org/#/c/2809/1/src/hlr.c
File src/hlr.c:

Line 438: 	hlr_vty_init(g_hlr, &hlr_log_info, hlr_ctx);
> g_hlr is also a talloc'd item, and it would indeed make more sense to use t
In other places like in hnbgw.c (osmo-iuh) the same is done as I do here (even passing the main talloc_ctx instead of the config object, and passing it as 2nd parameter). 

I'll drop the hlr_ctx parameter and use g_hlr for everything.


https://gerrit.osmocom.org/#/c/2809/1/src/hlr.h
File src/hlr.h:

Line 39: 	char *bind_addr;
> this should also say 'gsup_bind_addr'. (While at it, we could also add the 
Done


https://gerrit.osmocom.org/#/c/2809/1/src/hlr_vty.c
File src/hlr_vty.c:

Line 61:       "IPv4 Address to bind to\n")
> "GSUP"
Done


Line 65:         g_hlr->bind_addr = talloc_strdup(tall_hlr_ctx, argv[0]);
> s/tall_hlr_ctx/g_hlr
Done


https://gerrit.osmocom.org/#/c/2809/1/src/hlr_vty.h
File src/hlr_vty.h:

Line 35: void hlr_vty_init(struct hlr *hlr, const struct log_info *cat, void *tall_ctx);
> in most osmo code we pass the tall_ctx as first argument, if we have one.
Will not apply anymore as there will only be 1 parameter.


-- 
To view, visit https://gerrit.osmocom.org/2809
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I79f7a300480f308b21116dd14d1698be38725afd
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list