This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Patch Set 2: Code-Review+1
(2 comments)
https://gerrit.osmocom.org/#/c/3330/2/src/sccp_user.c
File src/sccp_user.c:
Line 250: memset(dest_addr, 0, sizeof(*dest_addr));
(btw when https://gerrit.osmocom.org/3341 is merged this isn't strictly needed. Btw btw, hfreyther, and now me too, tend to prefer clearing by assignment:
*dest_addr = (struct osmo_sccp_addr){};
but neither of these are important, just noting.)
Line 251: osmo_sccp_make_addr_pc_ssn(dest_addr, ss7->cfg.primary_pc, ssn);
build failure: it appears you need to #include <osmocom/sigtran/sccp_helpers.h>
--
To view, visit https://gerrit.osmocom.org/3330
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I371dc9132871aad3d8321ea13cf9fd69d76eff8f
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes