libosmo-sccp[master]: sccp: drive local address from given sccp instance

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Jul 24 12:16:49 UTC 2017


Patch Set 1: Code-Review-1

(4 comments)

https://gerrit.osmocom.org/#/c/3330/1//COMMIT_MSG
Commit Message:

Line 7: sccp: drive local address from given sccp instance
derive


Line 10: indicator and the pointcode. The latter one is always available
(SSN is equally important I guess)


https://gerrit.osmocom.org/#/c/3330/1/src/sccp_user.c
File src/sccp_user.c:

Line 250: 	dest_addr->ri = OSMO_SCCP_RI_SSN_PC;
We set RI to SSN_PC, but the resulting address has no SSN set. It would be safer API to require the caller to pass an SSN. Does that make sense in the intended callers of this function?


Line 252: 	dest_addr->pc = ss7->cfg.primary_pc;
Since we have osmo_sccp_make_addr_pc_ssn(), it would make sense to use that function instead of duplicating its content.


-- 
To view, visit https://gerrit.osmocom.org/3330
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I371dc9132871aad3d8321ea13cf9fd69d76eff8f
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list