openbsc[master]: sgsn: Convert cch_pdp to host order for libgtp

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Jul 20 17:02:37 UTC 2017


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/3307/1/openbsc/src/gprs/sgsn_libgtp.c
File openbsc/src/gprs/sgsn_libgtp.c:

Line 240: 		memcpy(&pdp->cch_pdp, TLVP_VAL(tp, OSMO_IE_GSM_CHARG_CHAR),
don't we have something like a "TLV as uint32_t in network byte order" rather than doing a memcpy followed by an in-place ntohs? Seems we only have it for msgb's as msgb_get_u16.  But what about osmo_load16be(TLVP_VAL(...)) ?


-- 
To view, visit https://gerrit.osmocom.org/3307
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I977aec2e2f8d57802e45f591754e5733562d5c2a
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list