[MERGED] osmo-gsm-tester[master]: aoip_smpp: Disable check in esme_ms_sms_storeforward due to ...

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged.

Change subject: aoip_smpp: Disable check in esme_ms_sms_storeforward due to known issue
......................................................................


aoip_smpp: Disable check in esme_ms_sms_storeforward due to known issue

A test case checked in that test is known to be failing at the moment
due to missing correct implementation bits for AoIP software.

Comment it in a separate commit so that is easy to revert it once we
have it implemented.

See OsmoSMSC #2354 for more information.

Change-Id: I12f8dbe1d6dc9a554438fda1e38b2e5e3245c320
---
M suites/aoip_smpp/esme_ms_sms_storeforward.py
1 file changed, 7 insertions(+), 6 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/suites/aoip_smpp/esme_ms_sms_storeforward.py b/suites/aoip_smpp/esme_ms_sms_storeforward.py
index 3e7e4f8..308ebf3 100755
--- a/suites/aoip_smpp/esme_ms_sms_storeforward.py
+++ b/suites/aoip_smpp/esme_ms_sms_storeforward.py
@@ -39,17 +39,18 @@
 msg = Sms(esme.msisdn, wrong_msisdn, 'smpp message with wrong dest')
 esme.run_method_expect_failure(SMPP_ESME_RINVDSTADR, esme.sms_send_wait_resp, msg, esme.MSGMODE_STOREFORWARD)
 
-print('sending sms, it will be stored...')
-msg = Sms(esme.msisdn, ms.msisdn, 'smpp send not-yet-registered message')
-umref = esme.sms_send_wait_resp(msg, esme.MSGMODE_STOREFORWARD, receipt=True)
+# Disabled due to known issue, see ticket OsmoSMSC #2354
+#print('sending sms, it will be stored...')
+#msg = Sms(esme.msisdn, ms.msisdn, 'smpp send not-yet-registered message')
+#umref = esme.sms_send_wait_resp(msg, esme.MSGMODE_STOREFORWARD, receipt=True)
 
 print('MS registers and will receive the SMS...')
 ms.connect(msc.mcc_mnc())
 wait(ms.is_connected, msc.mcc_mnc())
 wait(msc.subscriber_attached, ms)
-wait(ms.sms_was_received, msg)
-print('Waiting to receive and consume sms receipt with reference', umref)
-wait(esme.receipt_was_received, umref)
+#wait(ms.sms_was_received, msg)
+#print('Waiting to receive and consume sms receipt with reference', umref)
+#wait(esme.receipt_was_received, umref)
 
 print('checking MS can receive SMS while registered...')
 msg = Sms(esme.msisdn, ms.msisdn, 'smpp send already-registered message')

-- 
To view, visit https://gerrit.osmocom.org/3146
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I12f8dbe1d6dc9a554438fda1e38b2e5e3245c320
Gerrit-PatchSet: 3
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>