[MERGED] openbsc[master]: remove code disabling T3109 if configured to 0

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: remove code disabling T3109 if configured to 0
......................................................................


remove code disabling T3109 if configured to 0

We no longer permit timers with a 0 value, so this case can never
happen.  Also, if it should happen, I'd rather have a timter expiring
immediately (and breaking something) than not being started in the
first place.

Change-Id: Ibfcdd3ddc0155caee89c501498329bde247621a0
---
M openbsc/src/libbsc/abis_rsl.c
1 file changed, 0 insertions(+), 4 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/openbsc/src/libbsc/abis_rsl.c b/openbsc/src/libbsc/abis_rsl.c
index f537cf2..f4fd6de 100644
--- a/openbsc/src/libbsc/abis_rsl.c
+++ b/openbsc/src/libbsc/abis_rsl.c
@@ -2899,10 +2899,6 @@
 {
 	struct gsm_bts *bts = lchan->ts->trx->bts;
 
-	/* Disabled, mostly legacy code */
-	if (bts->network->T3109 == 0)
-		return -1;
-
 	osmo_timer_setup(&lchan->T3109, t3109_expired, lchan);
 	osmo_timer_schedule(&lchan->T3109, bts->network->T3109, 0);
 	return 0;

-- 
To view, visit https://gerrit.osmocom.org/3309
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibfcdd3ddc0155caee89c501498329bde247621a0
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder