This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 (4 comments) This should rather be two or three separate patches with more meaningful summaries than "improve API". I believe it would make sense to combine the osmo_sccp_addr_by_name part with the 'enable global addressbook search' patch. https://gerrit.osmocom.org/#/c/3293/1/src/osmo_ss7_vty.c File src/osmo_ss7_vty.c: Line 982: * \param[in] addr pointer to output the resulting sccp-address; \param[out] I would also welcome the name to contain 'dest', maybe dest_addr to make it more obvious that it's an out-parameter Line 983: * (set to NULL if not interested) (indent this second line to line up with the description?) Line 996: memcpy(addr, &entry->addr, sizeof(*addr)); rather addr = entry->addr; Line 1004: const char *osmo_sccp_name_by_addr(const struct osmo_sccp_addr *addr) Is this strictly an improvement of the API? -- To view, visit https://gerrit.osmocom.org/3293 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68209dd1b2c0aa94b1894637a22b5cc3a3ff1250 Gerrit-PatchSet: 1 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes