[MERGED] osmocom-bb[master]: VIRT-PHY: Use IPv4 multicast groups for private / local scope

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: VIRT-PHY: Use IPv4 multicast groups for private / local scope
......................................................................


VIRT-PHY: Use IPv4 multicast groups for private / local scope

The addresses in the original code make little sense:
* 224.0.0.1 is "All systems on this subnet" and not routed
  outside the local ethernet segment
* 225.0.0.1 is in a RESERVED range that shouldn't be used

Change-Id: I8e3acd745e65a6cfa70b681a440da6a59a1ed0b5
---
M src/host/virt_phy/include/virtphy/virtual_um.h
1 file changed, 7 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/host/virt_phy/include/virtphy/virtual_um.h b/src/host/virt_phy/include/virtphy/virtual_um.h
index 6e7c384..ac098dd 100644
--- a/src/host/virt_phy/include/virtphy/virtual_um.h
+++ b/src/host/virt_phy/include/virtphy/virtual_um.h
@@ -4,10 +4,15 @@
 #include <osmocom/core/msgb.h>
 #include "osmo_mcast_sock.h"
 
+/* We use multicast group addresses from the 239.192.0.0/14 rage, as
+ * those are designated by RFC2365 as "IPv4 Organization Local Scope,
+ * "... the space from which an organization should allocate sub-
+ *  ranges when defining scopes for private use." */
+
 #define VIRT_UM_MSGB_SIZE	256
-#define DEFAULT_MS_MCAST_GROUP "224.0.0.1"
+#define DEFAULT_MS_MCAST_GROUP	"239.193.23.1"
 #define DEFAULT_MS_MCAST_PORT 4729 /* IANA-registered port for GSMTAP */
-#define DEFAULT_BTS_MCAST_GROUP "225.0.0.1"
+#define DEFAULT_BTS_MCAST_GROUP	"239.193.23.2"
 #define DEFAULT_BTS_MCAST_PORT 4729 /* IANA-registered port for GSMTAP */
 
 struct virt_um_inst {

-- 
To view, visit https://gerrit.osmocom.org/3281
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8e3acd745e65a6cfa70b681a440da6a59a1ed0b5
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder