libosmocore[master]: add DLMGCP logging category for libosmo-mgcp

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Jul 18 11:00:57 UTC 2017


Patch Set 2:

> I really would prefer not to have a system-installed library with a
 > "stable" API for MGCP based on the existing code.

The alternative is to copy the previous internal libmgcp around. We would have copies in osmo-mgw, osmo-msc and osmo-bsc.

osmo-msc uses MGCP client code that is separate from the main MGCP-GW implementation. Moving the MGCP client code to osmo-msc is still fairly reasonable. But when we want to also couple an MGCP-GW with each BSC, we also need that same code in osmo-bsc.

osmo-bsc_nat is so far in osmo-bsc.git and makes extensive use of the libmgcp code. Copying that would be a large bit of code dup between osmo-mgw.git and osmo-bsc.git. Does it make sense to move osmo-bsc_nat to osmo-mgw.git?? I guess not, given the shared code with osmo-bsc.

So far I tend to like having a separate library for X to avoid code dup, and you seem to be rather opposed to exposing API. We need to agree on a strategy. Are we really forced to keep the APIs "stable"? If yes, does it really hurt that much to do so? Is code dup less trouble?

-- 
To view, visit https://gerrit.osmocom.org/3181
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09c587e2d59472cbde852d467d457254746d9e67
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-HasComments: No



More information about the gerrit-log mailing list