[PATCH] openbsc[master]: Fix regression causing loss of static system-information mes...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat Jul 15 20:55:29 UTC 2017


Review at  https://gerrit.osmocom.org/3261

Fix regression causing loss of static system-information messages

In commit 8b1a2f8cd7a81c6b8c7cdb0963dcf89de7c46100 we started to
initialize bts->si_valid to 0.  This means we are skipping the manually
configured static system information.

Instead, we have to initialize bts->si_valid to bts->si_mode_static,
i.e. start with those that are static and not to be auto-generated.

Found while developing
http://git.osmocom.org/osmo-ttcn3-hacks/tree/sysinfo

Change-Id: Iab9cc93cf6d54560a72cc393cc3721a8d10e04bf
Closes: #2367
---
M openbsc/src/libbsc/bsc_init.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/61/3261/1

diff --git a/openbsc/src/libbsc/bsc_init.c b/openbsc/src/libbsc/bsc_init.c
index ead21b4..1547255 100644
--- a/openbsc/src/libbsc/bsc_init.c
+++ b/openbsc/src/libbsc/bsc_init.c
@@ -139,7 +139,7 @@
 	bts->si_common.cell_sel_par.neci = bts->network->neci;
 
 	/* Zero, forget the state of the SIs */
-	bts->si_valid = 0;
+	bts->si_valid = bts->si_mode_static;
 
 	/* First, we determine which of the SI messages we actually need */
 

-- 
To view, visit https://gerrit.osmocom.org/3261
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab9cc93cf6d54560a72cc393cc3721a8d10e04bf
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>



More information about the gerrit-log mailing list