This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3244 to look at the new patch set (#5). VIRT-PHY: Fixed timeslot in gsmtap-msg on downlink which was always 0. Timeslot is not encoded in the chan_nr accessible in the channel description but was taken from there and so it was always 0. Change-Id: I881a1c61ea47399c9b1385fb220cd587e3593e82 --- M src/osmo-bts-virtual/scheduler_virtbts.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/44/3244/5 diff --git a/src/osmo-bts-virtual/scheduler_virtbts.c b/src/osmo-bts-virtual/scheduler_virtbts.c index 4b4def7..df6fbeb 100644 --- a/src/osmo-bts-virtual/scheduler_virtbts.c +++ b/src/osmo-bts-virtual/scheduler_virtbts.c @@ -72,6 +72,8 @@ uint8_t gsmtap_chantype; /* the GSMTAP channel */ rsl_dec_chan_nr(chdesc->chan_nr, &rsl_chantype, &subslot, ×lot); + /* the timeslot is not encoded in the chan_nr of the chdesc, and so has to be overwritten */ + timeslot = tn; /* in Osmocom, AGCH is only sent on ccch block 0. no idea why. this seems to cause false GSMTAP channel * types for agch and pch. */ if (rsl_chantype == RSL_CHAN_PCH_AGCH && L1SAP_FN2CCCHBLOCK(fn) == 0) -- To view, visit https://gerrit.osmocom.org/3244 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I881a1c61ea47399c9b1385fb220cd587e3593e82 Gerrit-PatchSet: 5 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: BastusIII <sebastian.stumpf87 at googlemail.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder