osmo-bts[master]: trx: avoid deactivating lchan on LCHAN_REL_ACT_REACT

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Jul 13 09:17:19 UTC 2017


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/3067/3/src/osmo-bts-trx/l1_if.c
File src/osmo-bts-trx/l1_if.c:

Line 112: 	if (lchan->rel_act_kind == LCHAN_REL_ACT_REACT) {
I can see *what* you are doing,but not why.  This looks more like a hack to work around a problem rather than a fix.  Which particular part of the code requires lchan->rel_act_kind to be LCHAN_REL_ACT_RSL further down the line?


-- 
To view, visit https://gerrit.osmocom.org/3067
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20b89ba1e43d1414180b083cd1e085eeffe5d513
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Alexander Chemeris <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Ivan Kluchnikov <kluchnikovi at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list